Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDA-4369: Ability to Cancel changes made on pod URL #1987

Merged
merged 1 commit into from
Oct 19, 2023
Merged

SDA-4369: Ability to Cancel changes made on pod URL #1987

merged 1 commit into from
Oct 19, 2023

Conversation

NguyenTranHoangSym
Copy link
Contributor

@NguyenTranHoangSym NguyenTranHoangSym commented Oct 18, 2023 •
edited
Loading

Description

  • Add a new button to help user cancel changes made
  • Adding fix to the issue related to document.location.href changed will make pod url went unchanged
  • Copy to clipboard will remove updatedHostName

Related PRs

Demo

image

Fr
image

JP
image

@NguyenTranHoangSym NguyenTranHoangSym mentioned this pull request Oct 19, 2023
Closed
@sbenmoussati sbenmoussati merged commit c6dbb20 into finos:main Oct 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KiranNiranjan KiranNiranjan KiranNiranjan approved these changes

@sbenmoussati sbenmoussati sbenmoussati approved these changes

Assignees

@NguyenTranHoangSym NguyenTranHoangSym

Labels
23.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NguyenTranHoangSym @KiranNiranjan @sbenmoussati