SDA-4453 - Memory leak issue on snipping tool #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbenmoussati
changed the title
sbenmoussati
force-pushed
the
bugfix/SDA-4453
branch
from
c0dc35e
to
63ebdf1
Compare
KiranNiranjan
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Snipping tool "close" and "upload" event handlers were being registered every time we created the snipping tool window, causing a memory leak issue + focus issues --> the window in question may have been destroyed in case we created/destroyed the child window that registered these handlers.
Also took the opportunity to upgrade electron to get the fix for CVE-2024-0518 and CVE-2024-0519