Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDA-4459 (Apply latest or beta channel based on user entitlement) #2086

Merged
merged 2 commits into from
Feb 12, 2024
Merged

SDA-4459 (Apply latest or beta channel based on user entitlement) #2086

merged 2 commits into from
Feb 12, 2024

Conversation

KiranNiranjan
Copy link
Member

@KiranNiranjan KiranNiranjan commented Jan 30, 2024 •
edited
Loading

Description

  • Apply the latest or beta channel based on user entitlement

PMP - sda-auto-update 🛑 - Auto update disabled

PMP - sda-auto-update 🟢 - Entitlement Visibility 🛑 - Latest Channel

PMP - sda-auto-update 🟢 - Entitlement Visibility 🟢 - Check for User Entitlements as below

Setting Channel
User Entitlement 🟢 User Entitlement Beta 🟢 Beta Channel
User Entitlement 🛑 User Entitlement Beta 🛑 Auto Update Diabled 🛑
User Entitlement 🟢 User Entitlement Beta 🛑 Latest Channel
User Entitlement 🛑 User Entitlement Beta 🟢 Beta Channel

User Entitlement = latestAutoUpdateChannelEnabled
User Entitlement Beta = betaAutoUpdateChannelEnabled

Entitlement Visibility = sdaInstallerMsiUrlEnabledVisible || sdaInstallerMsiUrlBetaEnabledVisible

Related PRs

SFE-Lite
BFF

@KiranNiranjan KiranNiranjan self-assigned this Jan 30, 2024
@KiranNiranjan
Copy link
Member Author

@sbenmoussati I have not modified the previous logic here https://github.com/finos/SymphonyElectron/pull/2086/files#diff-f616106d3e4dced6ea245a733db6b1e38c6a8be3a4689dc7b3581bcbba08bac5R262-R279 as the priority is cloud-config

@KiranNiranjan KiranNiranjan merged commit 8c0fa7b into finos:main Feb 12, 2024
6 checks passed
@KiranNiranjan KiranNiranjan deleted the SDA-4459 branch February 12, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbenmoussati sbenmoussati sbenmoussati approved these changes

@keerthi16 keerthi16 keerthi16 approved these changes

@NguyenTranHoangSym NguyenTranHoangSym Awaiting requested review from NguyenTranHoangSym

Assignees

@KiranNiranjan KiranNiranjan

Labels
24.3.0 master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KiranNiranjan @keerthi16 @sbenmoussati