-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REQUEST] Code Cleanup: Remove Unused Imports and Variables #856
Comments
Tagging @PaulaPaul , @aaronreed708 and @evangk6 for your views. |
@Sweetdevil144 can I go with the issue? |
Hi @rahat2134 . I've already finished working on this issue and maintained end to end code quality locally. I'm waiting for the maintainer's review to create a PR for the same. |
@Sweetdevil144 Thank you! Yes, we certainly have a lot of issues that lint would help with. If you have code ready to go, please submit a PR and I'll review it. Thank you for taking the time to open the issue and working on this! |
Opening a PR soon as I get to my room :) |
@aaronreed708 PR done and a custom However, No issues were found to stop deployments after addition of linting. |
fix #856 : Linter added for Code Cleanup
Code Cleanup Required
Suggestion/Concern
There are unused imports in some of the code files. For example, in one of the files, the hooks
useRef
anduseLayoutEffect
are imported from 'react' but are not used anywhere in the filecode/src/ui/src/pages/DesignSystemPage.tsx
. This is unnecessary and can lead to confusion.Proposed Solution
Perform a thorough review of the codebase to identify any unused imports, variables, or other code elements. Once identified, these should be removed to keep the codebase clean and efficient. This will also help in improving the readability of the code and reduce the complexity. We can also add linter features to the same and implement linting before testing to keep track of such future issues.
Although I realise that MAYBE these will be utilised in near future, maintaining code quality is also an aspect we'll need to look over.
The text was updated successfully, but these errors were encountered: