-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #856 : Linter added for Code Cleanup #875
Conversation
✅ Deploy Preview for glistening-gecko-6b417a ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing errors like this at the top of the output that is generated by npm run lint
:
/Users/aaron/git-finos/a11y-theme-builder/code/build/app.js
0:0 error Parsing error: ESLint was configured to run on `<tsconfigRootDir>/build/app.js` using `parserOptions.project`: <tsconfigRootDir>/tsconfig.json
However, that TSConfig does not include this file. Either:
- Change ESLint's list of included files to not include this file
- Change that TSConfig to include this file
- Create a new TSConfig that includes this file and include it in your parserOptions.project
Do you see them, too? Can they be resolved?
My bad. I forgot to add the |
As an addition to Linting, maybe we can also ad |
#876 is already underway for Prettier with a PR. No reason that we can't keep them separate. |
That fixed the parsing error, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this code looks just fine. I'll merge it. @Sweetdevil144 can you open an issue that can be used to create the PR to commit the updated/fixed code, please?
Sure. Shiting the convo to #897 |
Fixes #856
Linter Added to base location to detect Linting Issues.