Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #856 : Linter added for Code Cleanup #875

Merged
merged 3 commits into from
May 22, 2024

Conversation

Sweetdevil144
Copy link
Contributor

Fixes #856

Linter Added to base location to detect Linting Issues.

Copy link

netlify bot commented May 9, 2024

Deploy Preview for glistening-gecko-6b417a ready!

Name Link
🔨 Latest commit 8f4332e
🔍 Latest deploy log https://app.netlify.com/sites/glistening-gecko-6b417a/deploys/6647a35dacb88c00088547b4
😎 Deploy Preview https://deploy-preview-875--glistening-gecko-6b417a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@aaronreed708 aaronreed708 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing errors like this at the top of the output that is generated by npm run lint:

/Users/aaron/git-finos/a11y-theme-builder/code/build/app.js
  0:0  error  Parsing error: ESLint was configured to run on `<tsconfigRootDir>/build/app.js` using `parserOptions.project`: <tsconfigRootDir>/tsconfig.json
However, that TSConfig does not include this file. Either:
- Change ESLint's list of included files to not include this file
- Change that TSConfig to include this file
- Create a new TSConfig that includes this file and include it in your parserOptions.project

Do you see them, too? Can they be resolved?

@Sweetdevil144
Copy link
Contributor Author

Do you see them, too? Can they be resolved?

My bad. I forgot to add the ignorePatterns Property. This error may be fixed now. Can you verify it @aaronreed708 ?

@Sweetdevil144
Copy link
Contributor Author

As an addition to Linting, maybe we can also ad Prettier Formatting to this PR if you agree to do so @aaronreed708

@aaronreed708
Copy link
Contributor

#876 is already underway for Prettier with a PR. No reason that we can't keep them separate.

@aaronreed708
Copy link
Contributor

My bad. I forgot to add the ignorePatterns Property. This error may be fixed now. Can you verify it @aaronreed708 ?

That fixed the parsing error, thank you!

Copy link
Contributor

@aaronreed708 aaronreed708 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this code looks just fine. I'll merge it. @Sweetdevil144 can you open an issue that can be used to create the PR to commit the updated/fixed code, please?

@aaronreed708 aaronreed708 merged commit bcbefda into finos:dev May 22, 2024
5 checks passed
@Sweetdevil144 Sweetdevil144 deleted the dev-test branch May 22, 2024 05:38
@Sweetdevil144
Copy link
Contributor Author

Sure. Shiting the convo to #897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants