Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Make absolute links to the master branch relative #129

Merged
merged 1 commit into from Jul 1, 2021

Conversation

TLATER
Copy link
Contributor

@TLATER TLATER commented Jun 21, 2021

This helps with:

  1. Switching master -> main, since those links would otherwise point nowhere.
  2. Forks
  3. Clones not on GitHub

Links in GitHub README files should in general be relative, see the
relevant documentation
.

This helps with:

1. Switching master -> main, since those links would otherwise point nowhere.
2. Forks
3. Clones not on GitHub

Links in GitHub README files should in general be relative, see [the
relevant documentation][1].

[1]: https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/creating-a-repository-on-github/about-readmes#relative-links-and-image-paths-in-readme-files
@TLATER
Copy link
Contributor Author

TLATER commented Jun 21, 2021

Related to #119

@mcleo-d mcleo-d added this to To do in Compliant Financial Infrastructure via automation Jun 21, 2021
@mcleo-d mcleo-d added the ready for review Item ready for review by the wider community label Jun 21, 2021
@mcleo-d mcleo-d moved this from To do to Ready for Review in Compliant Financial Infrastructure Jun 21, 2021
Copy link
Contributor

@abdullahgarcia abdullahgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Compliant Financial Infrastructure automation moved this from Ready for Review to In progress Jun 22, 2021
@TLATER
Copy link
Contributor Author

TLATER commented Jun 22, 2021

Thanks @abdullahgarcia - I guess we need review from @peterrhysthomas for a merge too? I don't have permissions to push myself ;)

Copy link

@njwilliams njwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

Compliant Financial Infrastructure automation moved this from Ready for Review to In progress Jul 1, 2021
@@ -33,21 +33,21 @@ Find the [Cloud Service Certification Project Kanban](https://github.com/orgs/fi

## Service Approval Accelerator

The [Service Approval Accelerator](https://github.com/finos/cloud-service-certification/blob/master/templates/ServiceApprovalAcceleratorTemplate.md) describes each service contributed to Cloud Service Certification alongside test cases and infrastructure as code.
The [Service Approval Accelerator](templates/ServiceApprovalAcceleratorTemplate.md) describes each service contributed to Cloud Service Certification alongside test cases and infrastructure as code.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏻

Copy link
Contributor

@peterrhysthomas peterrhysthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present ready for review Item ready for review by the wider community
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants