Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Support mechanism to apply changes patch (handling conflicts) #470

Open
akphi opened this issue Sep 11, 2021 · 1 comment
Labels
Component: SDLC good first issue Good for newcomers Studio Core Team Opened by a member of the Studio core team Type: Feature Request
Milestone

Comments

@akphi
Copy link
Contributor

akphi commented Sep 11, 2021

Context and Motivation

We allow users to download a patch for their local changes, but there's no way to apply it. This might play out as a mini conflict-resolver (i.e. think of when we do git stash pop/apply and have to resolve the conflicts then), so the UI work might be quite involving. Nevertheless, this is a natural step to improve the current SDLC as it helps users recover their workspaces, and will help with working within a group workspace in particular (see #461)

Conflicts in patch and local changes will be handled by #756


UPDATE

Partially resolved in #748
We can follow what @MauricioUyaguari did in #749 to create a conflict resolution flow for patch applier.

Also, let's address the comments left in #748

@akphi akphi changed the title Feature request: Support mechanism to apply changes patch RFC: Support mechanism to apply changes patch Sep 11, 2021
@akphi akphi added the Studio Core Team Opened by a member of the Studio core team label Oct 29, 2021
@akphi akphi changed the title RFC: Support mechanism to apply changes patch Feature request: Support mechanism to apply changes patch Nov 6, 2021
@akphi akphi added this to the On Deck milestone Nov 18, 2021
@MauricioUyaguari MauricioUyaguari self-assigned this Nov 20, 2021
@akphi akphi modified the milestones: On Deck, 3.0.0 Nov 22, 2021
@akphi akphi changed the title Feature request: Support mechanism to apply changes patch Feature request: Support mechanism to apply changes patch (handling conflicts) Jan 20, 2022
@akphi akphi modified the milestones: 3.0.0, On Deck Jan 20, 2022
@akphi
Copy link
Contributor Author

akphi commented Jan 20, 2022

Moved this out of 3.0.0 as the core part is already handled in #748 . The enhancement to handle conflict resolution can be done later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: SDLC good first issue Good for newcomers Studio Core Team Opened by a member of the Studio core team Type: Feature Request
Projects
None yet
Development

No branches or pull requests

2 participants