Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Support updating out of sync workspaces (including conflict resolution) #756

Closed
6 tasks done
MauricioUyaguari opened this issue Dec 28, 2021 · 1 comment · Fixed by #749
Closed
6 tasks done
Assignees
Labels
Application: Studio Issues related to Legend Studio application Component: SDLC Studio Core Team Opened by a member of the Studio core team Type: Feature Request
Milestone

Comments

@MauricioUyaguari
Copy link
Member

MauricioUyaguari commented Dec 28, 2021

Similar requests

  • I have searched and found no existing similar requests

How are you using Studio?

Legend Studio

What problems are you trying to solve?

Provide an interface to users to handle local conflicts in changes.
For now this can occur in two situations

  • User current workspace revision is outdated with the head of workspace. Conflicts resulted in local changes vs base/head of workspace.
  • User apply patches and conflicts results from patch changes and local changes.

Describe the solution you would like to see implemented

  • Workspace conflict
    • Provide user notification when workspace is not in sync with head revision. i.e when saving, local change viewer
  • Main Conflict Resolution

Describe alternatives you have considered

No response

Documentation, Design, Adoption, Migration Strategy

No response

Contribution

  • I would like to work on this feature
@MauricioUyaguari MauricioUyaguari added this to the 3.0.0 milestone Dec 28, 2021
@MauricioUyaguari MauricioUyaguari self-assigned this Dec 28, 2021
@github-actions github-actions bot added the Studio Core Team Opened by a member of the Studio core team label Dec 28, 2021
@MauricioUyaguari MauricioUyaguari changed the title Feature request: Support Local Conflict Resolution to handle conflict in workspace revision and patch uploads Feature request: Support updating out of sync workspaces including Conflict Resolution Jan 11, 2022
@akphi akphi added Component: SDLC Application: Studio Issues related to Legend Studio application labels Feb 28, 2022
@akphi akphi changed the title Feature request: Support updating out of sync workspaces including Conflict Resolution Feature request: Support updating out of sync workspaces (including conflict resolution) Mar 2, 2022
@akphi
Copy link
Contributor

akphi commented Mar 2, 2022

Discussed with the highly sought-after @MauricioUyaguari and the decision is to leave model loader out of this. Model loader operation is imperative and will override anything as well as do a hard reload on the graph, there's no safety, conflict check we would need to do, but if we do hard save like in #191, we would probably need to do some safety check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Application: Studio Issues related to Legend Studio application Component: SDLC Studio Core Team Opened by a member of the Studio core team Type: Feature Request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants