Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to workspace head revision with conflict resolution #749

Merged
merged 4 commits into from
Jan 27, 2022

Conversation

MauricioUyaguari
Copy link
Member

@MauricioUyaguari MauricioUyaguari commented Dec 23, 2021

Summary

handle updating when current revision not in sync with workspace head
Closes #756

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

No Conflict

Screen.Recording.2022-02-08.at.10.02.58.PM.mov

Conflict

Screen.Recording.2022-02-08.at.10.04.41.PM.mov

Force Update

Screen.Recording.2022-02-08.at.10.14.50.PM.mov

@finos-cla-bot finos-cla-bot bot added the cla-present CLA Signed label Dec 23, 2021
@changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2021

🦋 Changeset detected

Latest commit: 0987dc0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
@finos/legend-studio Minor
@finos/legend-art Patch
@finos/legend-graph Patch
@finos/legend-model-storage Patch
@finos/legend-server-sdlc Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-serializer Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-external-language-morphir Patch
@finos/legend-extension-external-store-service Patch
@finos/legend-studio-app Patch
@finos/legend-studio-extension-management-toolkit Patch
@finos/legend-studio-extension-query-builder Patch
@finos/legend-application Patch
@finos/legend-manual-tests Patch
@finos/legend-query-app Patch
@finos/legend-query Patch
@finos/legend-taxonomy-app Patch
@finos/legend-taxonomy Patch
@finos/legend-extension-external-format-json-schema Patch
@finos/legend-server-depot Patch
@finos/legend-graph-extension-collection Patch
@finos/legend-studio-deployment Patch
@finos/legend-query-deployment Patch
@finos/legend-taxonomy-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #749 (0987dc0) into master (b8ee413) will decrease coverage by 0.29%.
The diff coverage is 18.67%.

@@            Coverage Diff             @@
##           master     #749      +/-   ##
==========================================
- Coverage   42.88%   42.59%   -0.30%     
==========================================
  Files         935      938       +3     
  Lines       41617    42073     +456     
  Branches     9591     9708     +117     
==========================================
+ Hits        17849    17921      +72     
- Misses      23694    24078     +384     
  Partials       74       74              
Impacted Files Coverage Δ
...graph/src/graphManager/AbstractPureGraphManager.ts 100.00% <ø> (ø)
...rc/models/protocols/pure/v1/V1_PureGraphManager.ts 59.62% <0.00%> (-0.35%) ⬇️
...ackages/legend-server-sdlc/src/SDLCServerClient.ts 0.50% <0.00%> (ø)
...dio/src/components/editor/edit-panel/EditPanel.tsx 59.23% <0.00%> (ø)
...io/src/components/editor/side-bar/LocalChanges.tsx 5.95% <0.00%> (-3.31%) ⬇️
...-studio/src/components/editor/side-bar/SideBar.tsx 33.33% <0.00%> (ø)
...egend-studio/src/components/review/ReviewPanel.tsx 14.28% <ø> (ø)
packages/legend-studio/src/stores/EditorConfig.ts 100.00% <ø> (ø)
packages/legend-studio/src/stores/ReviewStore.ts 0.00% <0.00%> (ø)
packages/legend-studio/src/stores/ViewerStore.ts 12.14% <0.00%> (ø)
... and 28 more

@MauricioUyaguari MauricioUyaguari changed the title temp Update to workspace head revision with conflict resolution Jan 7, 2022
@MauricioUyaguari MauricioUyaguari marked this pull request as ready for review January 7, 2022 23:32
@akphi
Copy link
Contributor

akphi commented Jan 10, 2022

@MauricioUyaguari you should rebase to dismiss the Whitesource warning.

Copy link
Contributor

@akphi akphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments: mostly has to do with the the decomsition of the term syncing workspace to push local changes and pull remote changes. The PR is massive and I don't have the best focus now so please do me a favor and be exhaustive in this process. Thanks!

@MauricioUyaguari
Copy link
Member Author

Left some minor comments: mostly has to do with the the decomsition of the term syncing workspace to push local changes and pull remote changes. The PR is massive and I don't have the best focus now so please do me a favor and be exhaustive in this process. Thanks!

@akphi
The agreed terminology (correct me if I'm wrong).
In terms of actions, we will use
pull/push changes
Pull changes refers to pulling in remote workspace changes.
Push changes refers to pushing local changes.

We will keep out-of-sync to describe the state of local and remote workspace being out-of-sync.
We will also keep the term outdated to describe when the workspace is outdated from the project master.
Good?

Copy link
Contributor

@akphi akphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So besides minor phrasing changes, I think for names of the stores, we should do WorkspaceSync...State because that state controls the logic for both direction push and pull.

akphi
akphi previously approved these changes Jan 27, 2022
@akphi akphi dismissed stale reviews from themself via 0987dc0 January 27, 2022 17:52
@MauricioUyaguari MauricioUyaguari merged commit 4e2eddb into finos:master Jan 27, 2022
akphi added a commit to akphi/legend-studio that referenced this pull request Jan 28, 2022
akphi added a commit that referenced this pull request Jan 29, 2022
* minor fixes to changeset publish script call

* add workaround for not pushing created Git tags

* remove ESLint rule no-duplicate-exports

* attempt to fix Sonar scanning

* taxonomy: support copying to clipboard taxnomy node ID if present

* bump dependencies

* add changeset

* update CODEOWNERS

* minor cleanups and fixes post #749

* add changeset

* minor fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Support updating out of sync workspaces (including conflict resolution)
2 participants