-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to workspace head revision with conflict resolution #749
Conversation
🦋 Changeset detectedLatest commit: 0987dc0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #749 +/- ##
==========================================
- Coverage 42.88% 42.59% -0.30%
==========================================
Files 935 938 +3
Lines 41617 42073 +456
Branches 9591 9708 +117
==========================================
+ Hits 17849 17921 +72
- Misses 23694 24078 +384
Partials 74 74
|
bc48847
to
b5d611e
Compare
4636ab7
to
1e796f4
Compare
070ddf2
to
c5ff1af
Compare
packages/legend-graph/src/graphManager/AbstractPureGraphManager.ts
Outdated
Show resolved
Hide resolved
packages/legend-studio/src/stores/sidebar-state/ConflictResolutionState.ts
Outdated
Show resolved
Hide resolved
packages/legend-studio/src/stores/sidebar-state/ConflictResolutionState.ts
Outdated
Show resolved
Hide resolved
packages/legend-studio/src/stores/sidebar-state/WorkspaceRevisionUpdaterState.ts
Outdated
Show resolved
Hide resolved
packages/legend-studio/src/stores/sidebar-state/ConflictResolutionState.ts
Outdated
Show resolved
Hide resolved
@MauricioUyaguari you should rebase to dismiss the Whitesource warning. |
6bf8361
to
e757418
Compare
0a0d311
to
cf37d9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments: mostly has to do with the the decomsition of the term syncing workspace
to push local changes
and pull remote changes
. The PR is massive and I don't have the best focus now so please do me a favor and be exhaustive in this process. Thanks!
packages/legend-studio/src/components/editor/side-bar/WorkspaceSyncConflictResolver.tsx
Show resolved
Hide resolved
packages/legend-studio/src/stores/sidebar-state/LocalChangesState.ts
Outdated
Show resolved
Hide resolved
packages/legend-studio/src/stores/sidebar-state/LocalChangesState.ts
Outdated
Show resolved
Hide resolved
packages/legend-studio/src/stores/sidebar-state/LocalChangesState.ts
Outdated
Show resolved
Hide resolved
packages/legend-studio/src/stores/sidebar-state/LocalChangesState.ts
Outdated
Show resolved
Hide resolved
@akphi We will keep out-of-sync to describe the state of local and remote workspace being |
0bd523d
to
806ae10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So besides minor phrasing changes, I think for names of the stores, we should do WorkspaceSync...State
because that state controls the logic for both direction push
and pull
.
packages/legend-studio/src/stores/sidebar-state/WorkspacePullState.ts
Outdated
Show resolved
Hide resolved
packages/legend-studio/src/components/editor/side-bar/WorkspacePullConflictResolver.tsx
Outdated
Show resolved
Hide resolved
packages/legend-studio/src/stores/sidebar-state/WorkspacePullState.ts
Outdated
Show resolved
Hide resolved
packages/legend-studio/src/stores/sidebar-state/WorkspacePullState.ts
Outdated
Show resolved
Hide resolved
packages/legend-studio/src/stores/sidebar-state/WorkspacePullState.ts
Outdated
Show resolved
Hide resolved
packages/legend-studio/src/stores/sidebar-state/WorkspacePullState.ts
Outdated
Show resolved
Hide resolved
packages/legend-studio/src/stores/sidebar-state/WorkspacePullState.ts
Outdated
Show resolved
Hide resolved
packages/legend-studio/src/stores/sidebar-state/WorkspacePullState.ts
Outdated
Show resolved
Hide resolved
packages/legend-studio/src/stores/sidebar-state/WorkspaceSyncState.ts
Outdated
Show resolved
Hide resolved
* minor fixes to changeset publish script call * add workaround for not pushing created Git tags * remove ESLint rule no-duplicate-exports * attempt to fix Sonar scanning * taxonomy: support copying to clipboard taxnomy node ID if present * bump dependencies * add changeset * update CODEOWNERS * minor cleanups and fixes post #749 * add changeset * minor fixes
Summary
handle updating when current revision not in sync with workspace head
Closes #756
How did you test this change?
No Conflict
Screen.Recording.2022-02-08.at.10.02.58.PM.mov
Conflict
Screen.Recording.2022-02-08.at.10.04.41.PM.mov
Force Update
Screen.Recording.2022-02-08.at.10.14.50.PM.mov