Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a proper Decimal type #90

Closed
DamianReeves opened this issue Jun 15, 2020 · 2 comments
Closed

Introduce a proper Decimal type #90

DamianReeves opened this issue Jun 15, 2020 · 2 comments

Comments

@DamianReeves
Copy link
Member

In order to allow representing proper precision in Elm we should include a proper Decimal type in SDK.
@snyk-bot snyk-bot mentioned this issue Sep 24, 2020
Open
@DamianAtWork
Copy link

The agreed upon approach is to add a Decimal type to the SDK that will be backed by https://package.elm-lang.org/packages/prikhi/decimal/latest/Decimal.

DamianReeves added a commit that referenced this issue Jan 20, 2021
@DamianReeves
Add Decimal type support in the SDK and Elm Frontend (#303)
1f9d52d 
* #90 - Adding the Decimal type to Morphir SDK and Elm FronteEnd

* #90 Adding additional functions to Decimal SDK

* #90 - Bring SDK and IR.SDK inline with each ither

* #90 - Added helpers for common powers of 10

* #90 - Allow usage of the Decimal type in the Elm Frontend
DamianReeves added a commit that referenced this issue Jan 20, 2021
@DamianReeves
#90 - finos/morphir-elm version 8.0.0 (#305)
5c13ad2
@snyk-bot snyk-bot mentioned this issue Jan 18, 2022
Open
@AttilaMihaly
Copy link
Member

Thais was done

sfc-gh-lfallasavendano pushed a commit to Snowflake-Labs/morphir-elm that referenced this issue Dec 13, 2023
@sfc-gh-aramirezfuentes @sfc-gh-lfallasavendano
Fix in the aggregate function with alias (finos#90)
c242992 
Fix alias name when is added in the aggregate function for the column
sfc-gh-lfallasavendano pushed a commit to Snowflake-Labs/morphir-elm that referenced this issue Dec 13, 2023
@sfc-gh-aramirezfuentes @sfc-gh-lfallasavendano
Fix in the aggregate function with alias (finos#90)
8207573 
Fix alias name when is added in the aggregate function for the column
sfc-gh-lfallasavendano pushed a commit to Snowflake-Labs/morphir-elm that referenced this issue Jan 2, 2024
@sfc-gh-aramirezfuentes @sfc-gh-lfallasavendano
Fix in the aggregate function with alias (finos#90)
6e642a8 
Fix alias name when is added in the aggregate function for the column
sfc-gh-lfallasavendano pushed a commit to Snowflake-Labs/morphir-elm that referenced this issue Jan 8, 2024
@sfc-gh-aramirezfuentes @sfc-gh-lfallasavendano
Fix in the aggregate function with alias (finos#90)
03efda3 
Fix alias name when is added in the aggregate function for the column
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DamianReeves @AttilaMihaly @DamianAtWork