Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Decimal type support in the SDK and Elm Frontend #303

Merged
merged 8 commits into from
Jan 20, 2021
Merged

Add Decimal type support in the SDK and Elm Frontend #303

merged 8 commits into from
Jan 20, 2021

Conversation

DamianReeves
Copy link
Member

@DamianReeves DamianReeves commented Jan 19, 2021 •
edited
Loading

Terms

THIS SOFTWARE IS CONTRIBUTED SUBJECT TO THE TERMS OF THE TERMS OF THE CCLA DATED 2017-11-07 WITH FINOS/LINUX FOUNDATION (FORMERLY THE SYMPHONY SOFTWARE FOUNDATION CCLA).

THIS SOFTWARE IS LICENSED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AND ANY WARRANTY OF NON-INFRINGEMENT, ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS.

@DamianReeves DamianReeves marked this pull request as draft January 19, 2021 23:12
AttilaMihaly
AttilaMihaly reviewed Jan 20, 2021
View reviewed changes
Copy link
Member

@AttilaMihaly AttilaMihaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far with the minor changes I mentioned.

src/Morphir/IR/SDK/Decimal.elm Outdated Show resolved Hide resolved
src/Morphir/SDK/Basics.elm Outdated Show resolved Hide resolved
@DamianReeves DamianReeves changed the title Adding the Int32 and Decimal types Add Decimal type support in the SDK and Elm Frontend Jan 20, 2021
@DamianReeves DamianReeves marked this pull request as ready for review January 20, 2021 21:14
@DamianReeves DamianReeves merged commit 1f9d52d into finos:master Jan 20, 2021
@DamianReeves DamianReeves deleted the sdk branch January 20, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamianAtWork DamianAtWork DamianAtWork left review comments

@AttilaMihaly AttilaMihaly AttilaMihaly approved these changes

Assignees
No one assigned
Labels
cla-present
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DamianReeves @AttilaMihaly @DamianAtWork