-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hypergrid 2.1.x #104
Closed
Closed
Hypergrid 2.1.x #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e6f897b
to
b949d3f
Compare
- estimate_range(grid) -> Range.estimate(grid) // new Range object - is_subrange(subRange, superRange) -> subRange.within(superRange) - isNaN expressions -> range.isInvalid()
- remove JPMC patches — some weren't being used, some weren't necessary, and the header row height calculation patch was removed in favor new props: - add `flatHeight` height of header row when no grouped column (absolute pixel height OR %-age of font height) with default of 250% to give the same result as the patch. (For other values, include in GroupedHeader options object.) - added `nestedHeight` height of each header subrow when there are grouped column (absolute pixel height OR %-age of font height) with default of 160% to give the same result as the patch. (For other values, include in GroupedHeader options object.) - add `{ paintBackground: null }` GroupedHeader option to turn off group label decoration (underlining, gradients, etc.) - bump Hypergrid to version `2.1.9` (the remaining items depend on fin-hypergrid/core@6a6fcb1) - truncated vertical grid rule lines so they don't overpaint group headers - add `clipRuleLines` property to GroupedHeader cell renderer to clip vertical rule lines to bottom of header row - add `{ clipRule: true }` GroupedHeader option
Superseded by 3.0 branch |
texodus
pushed a commit
that referenced
this pull request
Mar 25, 2019
Basic OHLC and Candlestick charts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new branch,
hypergrid-2.1.x
supersedes thehypergrid-2.1.6
branch whose name does not necessarily reflect the version in its tip. This branch contains all the same commits as that one — except rebased to "lastest" v0.1.9 (fa6a0a9) — so it's safe to delete it (the old branch, that is).This PR brings
./packages/perspective-viewer-hypergrid
up to date with the Hypergridv2.1.9
release (released today). It also adds a few more lines to./.gitignore
.