Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server mode for Jupyterlab PerspectiveWidget #1195

Merged
merged 5 commits into from
Sep 14, 2020
Merged

Conversation

texodus
Copy link
Member

@texodus texodus commented Sep 14, 2020

  • [@sc1f] Adds server kwarg to PerspectiveWidget() Jupyterlab widget. When True, the browser <perspective-viewer> will use a python, server-side Table() virtually, rather than creating a WebAssembly Table() and cloning the contents. This mode is great for extra-large datasets, but comes at the cost of client interactive performance, and server memory/CPU.
  • Fixes 2 discrepancies with the Javascript API:
    • Fixes missing offset (called psp_offset in wasm) for correcting column_only end_col values.
    • Adds id kwarg for to_columns(), which is equivalent to __index__ for 0-sided contexts, and __row_path__ otherwise, and is necessary for GUI features like persistent selection and editing.
  • Fixes a longstanding bug in perspective-jupyterlab which caused Create New Output derived viewers to be mis-sized.
  • Fixes perspective-viewer-datagrid to not swallow scroll events when fully-scrolled, for convenient notebook scrolling.
  • Switches perspective-jupyterlab to material-dense theme.

Screen Shot 2020-09-14 at 4 15 30 AM

Copy link
Contributor

@sc1f sc1f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally - looks good! Proper styling for the additional output view is nice.

@texodus texodus merged commit 3fc6d21 into master Sep 14, 2020
@texodus texodus deleted the widget-remote-deux branch September 14, 2020 17:53
@texodus texodus added enhancement Feature requests or improvements Jupyter Python labels Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements Jupyter Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants