Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix perspective-workspace and add monaco-editor-webpack-plugin compatibility to perspective-webpack-plugin #1662

Merged
merged 7 commits into from
Dec 11, 2021

Conversation

texodus
Copy link
Member

@texodus texodus commented Dec 10, 2021

  • Add support for multiplexing @finos/perspective and @finos/perspective-viewer modules to their ESM or UMD builds from the new esbuild script, which allows perspective-workspace to be subsequently used as a dependency without forcing a build type.

  • Fix perspective-workspace package metadata to export the internal lumino components for integration into Lumino apps.

  • Updates to the perspective-workspace theme:

    • Left-justified panel headers.
    • Add color level and border between <perspective-viewer> background and spacers.
    • Expand Global Filter resize bar to 8px, overlap layout left padding.
    • Remove Global Filter margins entirely.
  • Add monaco option to @finos/perspective-webpack-plugin which allows disabling Monaco compilation, which makes it easier to embed Perspective in an application which uses its own monaco-editor and monaco-editor-webpack-plugin.

  • Adds an example of Perspective + React + Monaco Editor in a single app, which uses Monaco's JSON support to show a live view of a <perspective-viewer> config.

    monaco-plugin

@timkpaine
Copy link
Member

this should take care of #1648? breaking change but will export the themes in src?

@texodus texodus changed the title Fix perspective-workspace exports Fix perspective-workspace and add monaco-editor-webpack-plugin compatibility to perspective-webpack-plugin Dec 10, 2021
@texodus
Copy link
Member Author

texodus commented Dec 10, 2021

@timkpaine I hadn't planned on it but fair enough, I said I would. As mentioned, this is going to get deprecated fully soon anyway, as we extend perspective's theme support to allow UI driven theming, light/dark from user preferences, etc. I'm also going to remove the /themes/ references from /examples/, so these remappings will only be for integration.

As maybe I failed to mention, this backport will only work from webpack - CDN paths will need to be updated.

@texodus texodus merged commit 3fd629e into master Dec 11, 2021
@texodus texodus deleted the workspace-tweaks branch December 11, 2021 04:42
@texodus texodus restored the workspace-tweaks branch December 11, 2021 05:12
@texodus texodus deleted the workspace-tweaks branch December 11, 2021 05:12
@texodus texodus added the enhancement Feature requests or improvements label Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Themes moved causing build errors
2 participants