New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: python binding/integration #212
Conversation
timkpaine
commented
Aug 26, 2018
•
edited by LukeSheard
edited by LukeSheard
- transfer pypi
- copyrights
- sub module?
ping @texodus and @deepankarsharma for thoughts on how to best do integrations. |
At first glance the Python binding code looks super clean, nice job! I will do a more detailed review sometime tomorrow. Some thoughts on how an integration could look like My preference would be for the Python (and future language bindings) to be licensed identically to Perspective under the same license and for the code to be merged into mainline (Rather than via submodules). Would love to hear thoughts from others about this. |
Thanks for the PR! This looks great but needs some work and planning before we can consider merge (or where even to merge it). I've cleaned it up a bit on the python branch for discussion & review. I concur with @deepankarsharma on all points above, especially the question of licensing which is a critical consideration. |