Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Releases #2294

Merged
merged 3 commits into from
Jul 17, 2023
Merged

Add GitHub Releases #2294

merged 3 commits into from
Jul 17, 2023

Conversation

texodus
Copy link
Member

@texodus texodus commented Jul 7, 2023

@texodus texodus changed the title Feature/add python wheels to release Add GitHub Releases Jul 7, 2023
@texodus
Copy link
Member Author

texodus commented Jul 9, 2023

@tdbgamer This build worked and created a release, but the release has no artifacts (already deleted):

Screenshot 2023-07-08 at 10 45 58 PM

I'm not sure how to interpret the output of the publish task, but clearly the wheels aren't being detected/downloaded even though the script itself is connecting and not erroring because it detects the JS assets (though it does not publish these to the release either):

Running a dry run, this WILL NOT publish. Set the env var COMMIT to publish.
Fetching page 1
Found 0 python folders, expected 17
Found 0 javascript folders, expected 10
Creating GitHub Release v0.0.0-test
Found 0 wheels, expected 17
Found 0 pkgs, expected 10
Uploading to pypi:
	
Uploading to npm:
	perspective-dist
	perspective-viewer-dist
	perspective-viewer-datagrid-dist
	perspective-viewer-d3fc-dist
	perspective-viewer-openlayers-dist
	perspective-workspace-dist
	perspective-jupyterlab-dist
	perspective-cli-dist
	perspective-esbuild-plugin-dist
	perspective-webpack-plugin-dist
Skipping twine/npm upload, marked as dry run.
Set env var COMMIT=1 to run fo real.

@texodus
Copy link
Member Author

texodus commented Jul 9, 2023

Upon closer inspection, I know exactly how to interpret this - we can't call the octokit workflow inspection REST API from within the workflow itself, as the workflow doesn't exist yet. So - looks like this approach to publishing is not going to work as written no matter what, we'll need to port to use the Actions' tasks to move the assets around in CI.

@texodus texodus force-pushed the feature/add-python-wheels-to-release branch 4 times, most recently from f80d640 to c9f5b83 Compare July 16, 2023 02:55
@texodus texodus force-pushed the feature/add-python-wheels-to-release branch from c9f5b83 to ff186da Compare July 16, 2023 18:13
@texodus texodus added the internal Internal refactoring and code quality improvement label Jul 16, 2023
@texodus texodus marked this pull request as ready for review July 16, 2023 20:03
@texodus texodus merged commit abbfff6 into master Jul 17, 2023
11 checks passed
@texodus texodus deleted the feature/add-python-wheels-to-release branch July 17, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal refactoring and code quality improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants