Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty column name validation in ExprTk editor #2302

Merged
merged 1 commit into from
Jul 15, 2023

Conversation

cyril-acquah80
Copy link
Contributor

@cyril-acquah80 cyril-acquah80 commented Jul 10, 2023

Removes empty column skip from parse_expression_strings in @finos/perspective. This allows validate_expressions to validate any empty columns

Fixes #2268

finos-perspective

@finos-cla-bot
Copy link

finos-cla-bot bot commented Jul 10, 2023

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@cyril-acquah80).

In order to sign a CLA with FINOS, just submit a Pull Request with a simple change to this file (adding an empty line, or some random text at the bottom); this will trigger the EasyCLA bot, which will post a comment to the Pull Request stating whether all PR contributors are covered by FINOS CLA; if not covered, the bot will post instructions on how to sign the CLA.

Thanks once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email help@finos.org for any questions.

cc @TheJuanAndOnly99 @mcleo-d

@finos-admin
Copy link
Member

@cla-bot[bot] check

@finos-cla-bot
Copy link

finos-cla-bot bot commented Jul 10, 2023

The cla-bot has been summoned, and re-checked this pull request!

@cyril-acquah80 cyril-acquah80 marked this pull request as draft July 10, 2023 17:05
@cyril-acquah80 cyril-acquah80 marked this pull request as ready for review July 10, 2023 17:06
@cyril-acquah80 cyril-acquah80 marked this pull request as draft July 10, 2023 17:06
@cyril-acquah80 cyril-acquah80 marked this pull request as ready for review July 10, 2023 17:06
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

In the future, we generally require tests to accompany bug fixes please. There are many available examples to choose from. Since this PR adds no new code, it's fair to make an exception and rely on the existing tests to assert that this behavior was unnecessary.

@texodus texodus merged commit 155c8f2 into finos:master Jul 15, 2023
10 checks passed
@texodus texodus added the bug Concrete, reproducible bugs label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty column names break validation in ExprTk editor
3 participants