Fix over-calculation in when loading data in perspective-viewer
#2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
force-pushed
the
fix-double-view
branch
19 times, most recently
from
149e88f
to
8647585
Compare
texodus
changed the title
perspective-viewer
texodus
force-pushed
the
fix-double-view
branch
from
8647585
to
4b13220
Compare
texodus
force-pushed
the
fix-double-view
branch
from
4b13220
to
30192b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue which caused
<perspective-viewer>to delete, then recalculate, the same view in some cases, particularly around initial-load time. With this PR,<perspective-viewer>now uses it's internal configuration struct's equality to determine if re-rendering should occur.