Remove Any Old Expressions from Codebase #2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ada-x64
force-pushed
the
chores/internal-expr-struct
branch
from
04ad070
to
0037059
Compare
|
I've updated this PR to add a timeout configuration to the fixture. Now any function that can take a |
ada-x64
force-pushed
the
chores/internal-expr-struct
branch
from
3d574a1
to
b7d0ab8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR looks huge but it's actually quite small!
It does two things:
Main changes occur in:
tools/perspective-test/src/js/fixture.ts(adds fixture)rust/perspective-viewer/test/js/settings.spec.js(uses the new log tracking functionality)packages/perspective-viewer-datagrid/src/js/model/create.js(fixes datagrid bug)The rest are dependency updates to use the fixture.