Number string formatting in datagrid #2539
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
integrate can_render_column_styles to viewer
initial datagrid integration
fix datagrid tests symbols integration
update migrations Co-authored-by: Davis Silverman <sinistersnare@users.noreply.github.com> Co-authored-by: Broch Stilley <brochington@gmail.com>
better column_config update repr
ada-x64
force-pushed
the
features/number-string-formatting
branch
from
1992abb
to
f575d97
Compare
|
Thanks for the PR! Superseded by #2563, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2521
This PR aims to create a universal number string formatter using the Intl.NumberFormat() constructor as the base datatype.
This PR creates a column settings control on the viewer and integrates it into the Datagrid. Further work will integrate this control into the D3FC plugins and the OpenLayers plugin.