Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix split_by with date/datetime columns #2545

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Fix split_by with date/datetime columns #2545

merged 1 commit into from
Feb 26, 2024

Conversation

texodus
Copy link
Member

@texodus texodus commented Feb 26, 2024

Fixes #2544 and fixes #2306.

When split_by with a column of type "date" or "datetime", the internal viewport data is returned with column paths helpfully formatted as strings (helpfully due to a legacy internal format which does not properly support mixed types in column paths just yet). However, the column_paths() methods still returns t_tscalar, which sometimes is the same as the string representation, but is not when the type is "date" or "datetime". This caused Datagrid column group headers to show up as POSIX timestamps, but also caused the column paths to fail lookup when populating the table itself, causing the column to appears as all null.

This PR changes the behavior of the column_paths() method to explicitly to_string() column path values, and adds a test for both the column_paths() API and a browser integration test for the Datagrid split_by with a "date" column

Before:
test-failed-1
After:
test-failed-1

@texodus texodus added the bug Concrete, reproducible bugs label Feb 26, 2024
@texodus texodus merged commit fda23d8 into master Feb 26, 2024
13 checks passed
@texodus texodus deleted the fix-split-by-date branch February 26, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs
Projects
None yet
1 participant