Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to LLVM 17 & fix Python/Windows build #2546

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

texodus
Copy link
Member

@texodus texodus commented Feb 27, 2024

  • Fixes a build regression in Windows/Python. Add clang-format, clang-tidy and clangd support for C++ development #2541 introduced clang-tidy as a lint pass, as well as a host of autofixes, one of which was to make create_mapping() C++ method const. However, in an #ifdef(windows) block, a member value was mutated in this method, causing compilation errors on Windows. This method is actually vestigial in current Perspective (it related to disk-backed Table implementations), but is still compiled. This PR simply fixes the compilation issue by removing const - in the future we should really move this functionality to a deprecated folder.
  • Updates clang-format and clang-tidy lint rules to use LLVM 17 (previously 16). Over the course of Improve C++/LSP/VSCode Integration #2467 Add clang-format, clang-tidy and clangd support for C++ development #2541 we discovered no good way to achieve both glibc 1.26 and llvm 17 support for the entire lint+build process on the GitHub Actions CI machines available, without potentially building LLVM from source as part of the build process, so we chose LLVM 16 as a compromise. However, further conflicts made this untenable still so we instead only use LLVM 16 for lint+tidy, which happens in a dedicated CI job (VM) which does not compile (or is JS which does not use system clang). Since we don't compile with this toolchain, there is no actual reason to limit it, so this PR updates to 17 and applies autofix.

@texodus texodus added the internal Internal refactoring and code quality improvement label Feb 27, 2024
@texodus texodus merged commit 0ea5b4e into master Feb 27, 2024
29 of 34 checks passed
@texodus texodus deleted the fix-windows-build branch February 27, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal refactoring and code quality improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant