Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test implicit index & remove extraneous example file #706

Merged
merged 3 commits into from
Sep 5, 2019
Merged

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Sep 3, 2019

This PR adds tests in the core engine to assert that behavior around implicit __INDEX__ columns work as expected, in that updates with the __INDEX__ column should behave like partial updates on the row ID specified in __INDEX__.

  • tests generation of implicit index column in to_format
  • tests reading of implicit index for 0, 1, and 2-sided views
  • removes extraneous schema.html in examples folder

@texodus
Copy link
Member

texodus commented Sep 5, 2019

Looks good, thanks for the PR!

@texodus texodus merged commit a0d8429 into master Sep 5, 2019
@texodus texodus deleted the index-test branch September 5, 2019 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants