Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to_csv to Python API #759

Merged
merged 3 commits into from
Oct 11, 2019
Merged

Add to_csv to Python API #759

merged 3 commits into from
Oct 11, 2019

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Oct 10, 2019

This PR adds and tests to_csv for the perspective-python API. The method itself uses pandas.DataFrame.to_csv, so it includes the index columns that come as part of dataframe construction.

python/perspective/perspective/table/view.py Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Oct 10, 2019

Codecov Report

Merging #759 into master will increase coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #759      +/-   ##
==========================================
+ Coverage   92.14%   92.42%   +0.28%     
==========================================
  Files          47       47              
  Lines        3042     3155     +113     
==========================================
+ Hits         2803     2916     +113     
  Misses        239      239
Impacted Files Coverage Δ
perspective/tests/table/test_to_format.py 100% <0%> (ø) ⬆️
perspective/table/view.py 81.89% <0%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aa52a9...0397423. Read the comment docs.

@texodus
Copy link
Member

texodus commented Oct 11, 2019

Thanks for the PR! Looks good!

@texodus texodus merged commit 5c73eb2 into master Oct 11, 2019
@texodus texodus deleted the py-csv branch October 11, 2019 02:15
@texodus texodus added the enhancement Feature requests or improvements label Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants