Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple views on JLab plugin #776

Merged
merged 2 commits into from
Oct 21, 2019
Merged

Multiple views on JLab plugin #776

merged 2 commits into from
Oct 21, 2019

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Oct 21, 2019

This PR allows for multiple output views on the same Jupyter widget - all operations are shared between the widget instances, so making a change to pivots, filter etc. in one rendered instance will change the other.

@sc1f sc1f changed the title JupyterLab plugin improvements Multiple views on JLab plugin Oct 21, 2019
@codecov-io
Copy link

Codecov Report

Merging #776 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #776      +/-   ##
==========================================
- Coverage   91.99%   91.96%   -0.03%     
==========================================
  Files          50       50              
  Lines        3359     3361       +2     
==========================================
+ Hits         3090     3091       +1     
- Misses        269      270       +1
Impacted Files Coverage Δ
perspective/core/widget.py 78.18% <0%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0894cd6...edf2384. Read the comment docs.

@texodus texodus merged commit 5d2c093 into master Oct 21, 2019
@texodus texodus deleted the jlab-view branch October 21, 2019 18:14
@texodus
Copy link
Member

texodus commented Oct 21, 2019

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants