Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datagrid header click-to-sort and assorted improvements #967

Merged
merged 4 commits into from
Mar 17, 2020

Conversation

texodus
Copy link
Member

@texodus texodus commented Mar 10, 2020

Adds column header click-to-sort to @finos/perspective-viewer-datagrid. This implementation differs slightly from the existing @finos/perspective-viewer-hypergrid in that:

  1. It is single-click rather than double-click.
  2. It supports multiple sorts on the same column, for row-and-column sort.
  3. Is style-able via CSS

Screen Shot 2020-03-10 at 2 35 29 AM

A few other small improvements:

  • Adds a tree-line renderer.
  • Debugger & profiler driven improvements to the double-buffering renderer, which optimizes framerate even further and reduces draw-in effect of updating the DOM.
  • Fixes @finos/perspective-viewer-datagrid to work nicely when switched out for another plugin.
  • Fixes column autosizing miscalculation when row and column pivot levels change.

@timkpaine timkpaine added enhancement Feature requests or improvements JS labels Mar 11, 2020
Copy link
Contributor

@zemeolotu zemeolotu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good!

@texodus texodus merged commit 70191c9 into master Mar 17, 2020
@texodus texodus deleted the datagrid-sort branch March 17, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants