Merge pull request #2 from fintechless/fix/cloudfront_distribution

Fix/cloudfront_distribution
fintechless · Jul 5, 2022 · 54f276f · 54f276f
2 parents d51e0cf + 69cc8c5
commit 54f276f
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 13 deletions.
diff --git a/iac/aws_cloudfront_distribution/locals.tf b/iac/aws_cloudfront_distribution/locals.tf
@@ -1,4 +1,7 @@
 locals {
+  s3_active_origin_id  = "ftl-active-s3-origin"
+  s3_passive_origin_id = "ftl-passive-s3-origin"
+
   config_active = {
     region = local.ftl_active
     bucket = replace(local.ftl_bucket, data.aws_region.this.name, local.ftl_active)

diff --git a/iac/aws_cloudfront_distribution/main.tf b/iac/aws_cloudfront_distribution/main.tf
@@ -2,7 +2,7 @@ resource "aws_cloudfront_distribution" "this" {
   count = (data.aws_region.this.name == local.ftl_active) ? 1 : 0
 
   enabled = true
-  aliases = toset(split(",", local.ftl_fqdn_app))
+  aliases = local.ftl_domain != "" ? toset(split(",", local.ftl_fqdn_app)) : null
   comment = local.ftl_fqdn_app
 
   custom_error_response {
@@ -47,7 +47,7 @@ resource "aws_cloudfront_distribution" "this" {
   }
 
   origin {
-    origin_id   = data.terraform_remote_state.bucket_active.outputs.bucket_regional_domain_name
+    origin_id   = local.ftl_domain != "" ? data.terraform_remote_state.bucket_active.outputs.bucket_regional_domain_name : local.s3_active_origin_id
     domain_name = data.terraform_remote_state.bucket_active.outputs.bucket_regional_domain_name
     origin_path = ""
 
@@ -57,7 +57,7 @@ resource "aws_cloudfront_distribution" "this" {
   }
 
   origin {
-    origin_id   = data.terraform_remote_state.bucket_passive.outputs.bucket_regional_domain_name
+    origin_id   = local.ftl_domain != "" ? data.terraform_remote_state.bucket_passive.outputs.bucket_regional_domain_name : local.s3_passive_origin_id
     domain_name = data.terraform_remote_state.bucket_passive.outputs.bucket_regional_domain_name
     origin_path = ""
 
@@ -74,11 +74,11 @@ resource "aws_cloudfront_distribution" "this" {
     }
 
     member {
-      origin_id = data.terraform_remote_state.bucket_active.outputs.bucket_regional_domain_name
+      origin_id = local.ftl_domain != "" ? data.terraform_remote_state.bucket_active.outputs.bucket_regional_domain_name : local.s3_active_origin_id
     }
 
     member {
-      origin_id = data.terraform_remote_state.bucket_passive.outputs.bucket_regional_domain_name
+      origin_id = local.ftl_domain != "" ? data.terraform_remote_state.bucket_passive.outputs.bucket_regional_domain_name : local.s3_passive_origin_id
     }
   }
 
@@ -89,13 +89,11 @@ resource "aws_cloudfront_distribution" "this" {
     }
   }
 
-  dynamic "viewer_certificate" {
-    for_each = local.ftl_domain == "" ? [] : [null]
-    content {
-      acm_certificate_arn      = data.aws_acm_certificate.this[0].arn
-      ssl_support_method       = "sni-only"
-      minimum_protocol_version = "TLSv1.1_2016"
-    }
+  viewer_certificate {
+    cloudfront_default_certificate = local.ftl_domain != "" ? false : true
+    acm_certificate_arn            = local.ftl_domain != "" ? data.aws_acm_certificate.this[0].arn : null
+    ssl_support_method             = local.ftl_domain != "" ? "sni-only" : null
+    minimum_protocol_version       = local.ftl_domain != "" ? "TLSv1.1_2016" : null
   }
 
   tags = merge(var.tags, { Name = local.ftl_fqdn_app })

diff --git a/iac/aws_s3_website/main.tf b/iac/aws_s3_website/main.tf
@@ -32,6 +32,6 @@ resource "aws_secretsmanager_secret_version" "this" {
   depends_on = [aws_s3_bucket.this]
   secret_id  = data.aws_secretsmanager_secret.this.id
   secret_string = jsonencode(merge(local.ftl_cicd_secret_map, {
-    FTL_FQDN_APP = local.ftl_domain == "" ? format("%s.%s", local.ftl_env == "default" ? local.ftl_subdomain_app : "${local.ftl_subdomain_app}-${local.ftl_env}", local.ftl_domain) : aws_s3_bucket.this.bucket_regional_domain_name
+    FTL_FQDN_APP = local.ftl_domain != "" ? format("%s.%s", local.ftl_env == "default" ? local.ftl_subdomain_app : "${local.ftl_subdomain_app}-${local.ftl_env}", local.ftl_domain) : aws_s3_bucket.this.bucket_regional_domain_name
   }))
 }