Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/cloudfront_distribution #2

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Fix/cloudfront_distribution #2

merged 1 commit into from
Jul 5, 2022

Conversation

euliancom
Copy link
Contributor

Description

  • fixed cloudfront_distribution

Type of Changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a change to the documentation

How Has This Been Tested?

Test Configuration

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have checked that my changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@euliancom euliancom requested a review from eistrati July 5, 2022 20:30
@eistrati eistrati merged commit 54f276f into main Jul 5, 2022
@eistrati eistrati deleted the fix/cloudfront_distribution branch July 5, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eistrati eistrati eistrati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@euliancom @eistrati