Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonRPC improvements #122

Merged
merged 3 commits into from
Dec 20, 2013
Merged

JsonRPC improvements #122

merged 3 commits into from
Dec 20, 2013

Conversation

staaas
Copy link

@staaas staaas commented Dec 19, 2013

The PR contains patches, that make JsorpcRequestHandler compatible with jsonrpclib:

I've also added support of httpclient.fetch's arguments to httpclient.JsonRPC in order to support proxy, timeouts, etc.

By the way, thanks for Cyclone, it's awesome :)

@staaas staaas mentioned this pull request Dec 19, 2013
Closed
fiorix added a commit that referenced this pull request Dec 20, 2013
@fiorix
Merge pull request #122 from nott/jsonrpc
4bd61d0 
JsonRPC improvements
@fiorix fiorix merged commit 4bd61d0 into fiorix:master Dec 20, 2013
@fiorix
Copy link
Owner

fiorix commented Dec 20, 2013

Amazing, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JsonrpcRequestHandler shouldn't force request id to by int
2 participants
@staaas @fiorix