Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/unittesting #135

Merged
merged 15 commits into from
Aug 2, 2014
Merged

Feature/unittesting #135

merged 15 commits into from
Aug 2, 2014

Conversation

dpnova
Copy link
Collaborator

@dpnova dpnova commented Jul 31, 2014

Just something for you to have a look at @fiorix

There's a few things in this PR, which is not finished, but should start the conversation at least:

  1. A unit testing tool for testing handlers. So far it handles both instant and deferred responses.
  2. Started adding unit tests for cyclone itself. Thus far only the http client and the new test case class + client.
  3. A requirements file - I've included mock in there, but maybe it shoudn't be there.

To run the tests simply run trial cyclone

This obviously starts to deal with this issue: #132

Let me know what you think mate! If you're keen then I'll keep on with adding unit tests to the lib and document how to write unit tests for cyclone handlers. We could look at adding travis and coveralls integration as well.

@dpnova
Copy link
Collaborator Author

dpnova commented Jul 31, 2014

I added a travis config and tests are passing now: https://travis-ci.org/dpnova/cyclone

@dpnova
Copy link
Collaborator Author

dpnova commented Jul 31, 2014

Travis and Coveralls seems happy:

https://coveralls.io/r/dpnova/cyclone
https://travis-ci.org/dpnova/cyclone

@fiorix
Copy link
Owner

fiorix commented Jul 31, 2014

Please fix the copyright year and I'll merge it in.

@dpnova
Copy link
Collaborator Author

dpnova commented Aug 2, 2014

I've fixed the date thanks @fiorix

Could I ask you to enable the travis + coveralls accounts? All you have to do is go to each of the services and enable it for the cyclone repo. Everything else should be configured to just work.

Once they are hooked up I'll add the snippets to the readme to display the badges.

Cheers!

fiorix added a commit that referenced this pull request Aug 2, 2014
@fiorix fiorix merged commit d35b722 into fiorix:master Aug 2, 2014
@fiorix
Copy link
Owner

fiorix commented Aug 2, 2014

Done. Travis and Coveralls enabled. :)

@fiorix
Copy link
Owner

fiorix commented Aug 2, 2014

@hodgestar
Copy link

Thank you! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants