Implement unit testing by means of Tox #172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evilaliv3
force-pushed
the
tox
branch
2 times, most recently
from
1cad80a
to
c77617e
Compare
|
I've never used tox, been away from python for quite a while.. will leave this one to @dpnova. |
| @@ -149,7 +149,7 @@ def test_object_dict(self): | |||
| def test_import_object(self): | |||
| import os.path | |||
| other_os = import_object("os.path") | |||
| self.assertIs(os.path, other_os) | |||
| self.assertIdentical(os.path, other_os) | |||
There was a problem hiding this comment.
Is assertIdentical in python 2.7 @evilaliv3 ?
|
Aside from my one question this is looking good @evilaliv3 @fiorix - the move to tox will be good for catching edge cases with versions of python/twisted we don't all use ourselves. |
|
yes @dpnova the one is the alias of the other: https://github.com/twisted/twisted/blob/trunk/twisted/trial/_synctest.py#L454 |
Closed
|
awesome. but need to resolved conflicts |
|
Should be easy to resolve @evilaliv3 - I'll accept it once it's sorted as this is a good step. |
|
Stuck for too long and conflicting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit i've switched unit-tests to use Tox
This way we could start testing properly against the different versions of python (at least 2.7 and 3.5) as for ticket #171
With this pull request: