Only split headers on \n and \r\n #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
mstojcevich
commented
Oct 6, 2019
| @@ -265,7 +268,7 @@ def parse_multipart_form_data(boundary, data, arguments, files): | |||
| if eoh == -1: | |||
| log.msg("multipart/form-data missing headers") | |||
| continue | |||
| headers = HTTPHeaders.parse(part[:eoh]) | |||
| headers = HTTPHeaders.parse(to_unicode(part[:eoh])) | |||
There was a problem hiding this comment.
HTTPHeaders.parse is also used in cyclone.httpserver, that usage also converts the argument to unicode first.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of
splitlinescan be problematic when used with certain characters in a unicode string:During the Python 3 port, Cyclone started explicitly converting the body bytes to unicode when calling
HTTPHeaders.parse, which exposes this odd behavior.This PR changes the behavior to better match the HTTP RFCs. See the tests for more info.