forked from tornadoweb/tornado
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only split headers on \n and \r\n #189
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
from twisted.trial import unittest | ||
|
||
from cyclone.httputil import HTTPHeaders | ||
|
||
|
||
class TestHTTPHeaders(unittest.TestCase): | ||
def test_parse_no_cr(self): | ||
""" | ||
https://www.w3.org/Protocols/rfc2616/rfc2616-sec19.html#sec19.3 | ||
"The line terminator for message-header fields is the sequence CRLF. | ||
However, we recommend that applications, when parsing such headers, | ||
recognize a single LF as a line terminator and ignore the leading CR." | ||
|
||
https://tools.ietf.org/html/rfc7230#section-3.5 | ||
"Although the line terminator for the start-line and header fields is | ||
the sequence CRLF, a recipient MAY recognize a single LF as a line | ||
terminator and ignore any preceding CR." | ||
""" | ||
header_data = u"Foo: bar\n" u"Baz: qux" | ||
headers = HTTPHeaders.parse(header_data) | ||
self.assertEqual(len(list(headers.get_all())), 2) | ||
self.assertEqual(headers.get("foo"), "bar") | ||
self.assertEqual(headers.get("baz"), "qux") | ||
|
||
def test_parse_crlf(self): | ||
""" | ||
https://www.w3.org/Protocols/rfc2616/rfc2616-sec19.html#sec19.3 | ||
"The line terminator for message-header fields is the sequence CRLF. | ||
However, we recommend that applications, when parsing such headers, | ||
recognize a single LF as a line terminator and ignore the leading CR." | ||
""" | ||
header_data = u"Foo: bar\r\n" u"Baz: qux" | ||
headers = HTTPHeaders.parse(header_data) | ||
self.assertEqual(len(list(headers.get_all())), 2) | ||
self.assertEqual(headers.get("foo"), "bar") | ||
self.assertEqual(headers.get("baz"), "qux") | ||
|
||
def test_parse_problematic_newlines(self): | ||
""" | ||
There are some problematic characters that Python considers to be newlines | ||
for the purpose of splitlines, but aren't newlines per the RFCs. | ||
|
||
https://docs.python.org/3/library/stdtypes.html#str.splitlines | ||
""" | ||
header_data = ( | ||
u"Foo: bar\x0b\x0c\x1c\x1d\x1e\x85\u2028\u2029asdf: jkl\r\n" u"Baz: qux" | ||
) | ||
headers = HTTPHeaders.parse(header_data) | ||
self.assertEqual(len(list(headers.get_all())), 2) | ||
self.assertEqual( | ||
headers.get("foo"), u"bar\x0b\x0c\x1c\x1d\x1e\x85\u2028\u2029asdf: jkl" | ||
) | ||
self.assertEqual(headers.get("baz"), "qux") |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HTTPHeaders.parse is also used in cyclone.httpserver, that usage also converts the argument to unicode first.