Fix generating send encodings #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returning an object from an arrow function requires an extra hoop.
|
oh why did that work before? |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 16, 2020
which need an extra curly braces since this should be an object as shown in https://w3c.github.io/webrtc-pc/#rtcrtpencodingspatialsim-example* Noticed in fippo/simulcast-playground#7 BUG=None Change-Id: I176a2919a3dbd3e6b065dca9dcef357a1e2adc01
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 16, 2020
which need an extra curly braces since this should be an object as shown in https://w3c.github.io/webrtc-pc/#rtcrtpencodingspatialsim-example* Noticed in fippo/simulcast-playground#7 BUG=None Change-Id: I176a2919a3dbd3e6b065dca9dcef357a1e2adc01
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 18, 2020
which need an extra parenthesis since this should be an object as shown in https://w3c.github.io/webrtc-pc/#rtcrtpencodingspatialsim-example* Noticed in fippo/simulcast-playground#7 BUG=None Change-Id: I176a2919a3dbd3e6b065dca9dcef357a1e2adc01
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 18, 2020
which need an extra parenthesis since this should be an object as shown in https://w3c.github.io/webrtc-pc/#rtcrtpencodingspatialsim-example* Noticed in fippo/simulcast-playground#7 BUG=None Change-Id: I176a2919a3dbd3e6b065dca9dcef357a1e2adc01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247035 Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#779785}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 18, 2020
which need an extra parenthesis since this should be an object as shown in https://w3c.github.io/webrtc-pc/#rtcrtpencodingspatialsim-example* Noticed in fippo/simulcast-playground#7 BUG=None Change-Id: I176a2919a3dbd3e6b065dca9dcef357a1e2adc01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247035 Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#779785}
pull bot
pushed a commit
to Alan-love/chromium
that referenced
this pull request
Jun 18, 2020
which need an extra parenthesis since this should be an object as shown in https://w3c.github.io/webrtc-pc/#rtcrtpencodingspatialsim-example* Noticed in fippo/simulcast-playground#7 BUG=None Change-Id: I176a2919a3dbd3e6b065dca9dcef357a1e2adc01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247035 Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#779785}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 23, 2020
Automatic update from web-platform-tests wpt: fix webrtc simulcast rids which need an extra parenthesis since this should be an object as shown in https://w3c.github.io/webrtc-pc/#rtcrtpencodingspatialsim-example* Noticed in fippo/simulcast-playground#7 BUG=None Change-Id: I176a2919a3dbd3e6b065dca9dcef357a1e2adc01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247035 Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#779785} -- wpt-commits: 52a9f1c847e094e7925ae69bcc5bf4ff40826e45 wpt-pr: 24171
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Jun 26, 2020
Automatic update from web-platform-tests wpt: fix webrtc simulcast rids which need an extra parenthesis since this should be an object as shown in https://w3c.github.io/webrtc-pc/#rtcrtpencodingspatialsim-example* Noticed in fippo/simulcast-playground#7 BUG=None Change-Id: I176a2919a3dbd3e6b065dca9dcef357a1e2adc01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247035 Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#779785} -- wpt-commits: 52a9f1c847e094e7925ae69bcc5bf4ff40826e45 wpt-pr: 24171
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
which need an extra parenthesis since this should be an object as shown in https://w3c.github.io/webrtc-pc/#rtcrtpencodingspatialsim-example* Noticed in fippo/simulcast-playground#7 BUG=None Change-Id: I176a2919a3dbd3e6b065dca9dcef357a1e2adc01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247035 Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#779785} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: d4954632c8e2f8e16970e30b55e3e52df7eb13bb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning an object from an arrow function requires an extra hoop.