Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui_auth): fix confirmation dialog for delete account button #346

Merged
merged 3 commits into from
May 14, 2024

Conversation

TimBaumgart
Copy link
Contributor

Description

previously the wrong navigator was popped when cancelling or confirming the dialog. this resulted in the dialog still beeing visible and the navigator behind it beeing popped. the fix adds the context object to the function parameter, so the right navigator gets popped.

Related Issues

fixes #212

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • All unit tests pass (melos run test:unit:all doesn't fail).
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

…auth ui

previously the wrong navigator was popped when cancelling or confirming the dialog. this resulted in the dialog still beeing visible and the navigator behind it beeing popped. the fix adds the context object to the function parameter, so the right navigator gets popped.
@russellwheatley russellwheatley changed the title fix(ui_auth): fix confirmation dialog fix(ui_auth): fix confirmation dialog for delete account button May 14, 2024
@russellwheatley russellwheatley merged commit 4fd041d into firebase:main May 14, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 'Cancel' and 'Delete' actions of showDeleteConfirmationDialog pop the current view
2 participants