Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ClassNotFoundException for com.google.firebase.remoteconfig.ktx.… #1209

Merged
merged 1 commit into from Apr 24, 2020

Conversation

b95505017
Copy link
Contributor

…FirebaseConfigKtxRegistrar

Should be FirebaseRemoteConfigKtxRegistrar

…irebaseConfigKtxRegistrar

Should be `FirebaseRemoteConfigKtxRegistrar`
@google-oss-bot
Copy link
Contributor

Hi @b95505017. Thanks for your PR.

I'm waiting for a firebase member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rlazo
Copy link
Collaborator

rlazo commented Feb 6, 2020

Hi @b95505017 Great catch! Please, also add to your PR the missing test that should have caught this earlier.

 @RunWith(RobolectricTestRunner::class)
  class LibraryVersionTest : BaseTestCase() {
      @Test
      fun `library version should be registered with runtime`() {
          val publisher = Firebase.app.get(UserAgentPublisher::class.java)
          assertThat(publisher.userAgent).contains(LIBRARY_NAME)
      }
  }

Thank you for contributing to Firebase!

@rlazo
Copy link
Collaborator

rlazo commented Feb 6, 2020

/ok-to-test

@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #1209 into master will increase coverage by 45.34%.
The diff coverage is n/a.

Flag Coverage Δ Complexity Δ
#Encoders_FirebaseEncodersJson ? ?
#Encoders_FirebaseEncodersProcessor ? ?
#Encoders_FirebaseEncodersReflective ? ?
#FirebaseAbt ? ?
#FirebaseCommon ? ?
#FirebaseCommon_DataCollectionTests ? ?
#FirebaseCommon_Ktx ? ?
#FirebaseComponents ? ?
#FirebaseConfig ? ?
#FirebaseConfig_Ktx 100% <ø> (ø) 0 <ø> (ø) ⬇️
#FirebaseCrashlytics ? ?
#FirebaseDatabase ? ?
#FirebaseDatabaseCollection ? ?
#FirebaseDatabase_Ktx ? ?
#FirebaseDatatransport ? ?
#FirebaseDynamicLinks ? ?
#FirebaseDynamicLinks_Ktx ? ?
#FirebaseFirestore ? ?
#FirebaseFirestore_Ktx ? ?
#FirebaseFunctions ? ?
#FirebaseFunctions_Ktx ? ?
#FirebaseInappmessaging ? ?
#FirebaseInappmessagingDisplay ? ?
#FirebaseInappmessagingDisplay_Ktx ? ?
#FirebaseInappmessaging_Ktx ? ?
#FirebaseInstallations ? ?
#FirebaseSegmentation ? ?
#FirebaseStorage ? ?
#FirebaseStorage_Ktx ? ?
#Tools_Errorprone ? ?
#Tools_Lint ? ?
#Transport_TransportBackendCct ? ?
#Transport_TransportRuntime ? ?
Impacted Files Coverage Δ Complexity Δ
.../inappmessaging/internal/AbtIntegrationHelper.java
...atabase/collection/ImmutableSortedMapIterator.java
...ndroid/datatransport/cct/internal/LogResponse.java
.../main/java/com/google/firebase/firestore/Blob.java
...ng/internal/injection/modules/RateLimitModule.java
...om/google/firebase/firestore/SnapshotMetadata.java
...ytics/internal/settings/SettingsCacheBehavior.java
...ndroid/datatransport/runtime/TransportContext.java
...cs/internal/settings/network/UpdateAppSpiCall.java
...le/firebase/storage/network/GetNetworkRequest.java
... and 688 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79f91d7...192457d. Read the comment docs.

@wbervoets
Copy link

any update when this will be fixed in a released version?

@rlazo
Copy link
Collaborator

rlazo commented Apr 24, 2020

Thanks for the heads up @wbervoets I'll approve and merge this CL as-is, and add the missing test in a follow-up PR. Thanks for your contribution to Firebase @b95505017 !

@rlazo rlazo merged commit 7ecdf0e into firebase:master Apr 24, 2020
@firebase firebase locked and limited conversation to collaborators May 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants