Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing test to RemoteConfig KTX #1501

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Add missing test to RemoteConfig KTX #1501

merged 1 commit into from
Apr 28, 2020

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Apr 24, 2020

No description provided.

@googlebot googlebot added the cla: yes Override cla label Apr 24, 2020
@rlazo
Copy link
Collaborator Author

rlazo commented Apr 24, 2020

This is a follow up to #1209

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

No changes between base commit (7ecdf0e) and head commit (0bdeb94).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-abt

    Type Base (7ecdf0e) Head (0bdeb94) Diff
    apk (debug) 894 kB 894 kB -11 B (-0.0%)

  • firebase-common

    Type Base (7ecdf0e) Head (0bdeb94) Diff
    apk (aggressive) 82.5 kB 82.5 kB +17 B (+0.0%)
    apk (debug) 770 kB 770 kB -55 B (-0.0%)

  • firebase-common-ktx

    Type Base (7ecdf0e) Head (0bdeb94) Diff
    apk (aggressive) 264 kB 264 kB -1 B (-0.0%)
    apk (debug) 1.52 MB 1.52 MB -81 B (-0.0%)

  • firebase-components

    Type Base (7ecdf0e) Head (0bdeb94) Diff
    apk (debug) 35.8 kB 35.8 kB -2 B (-0.0%)

  • firebase-config

    Type Base (7ecdf0e) Head (0bdeb94) Diff
    apk (debug) 1.34 MB 1.34 MB -18 B (-0.0%)

  • firebase-config-ktx

    Type Base (7ecdf0e) Head (0bdeb94) Diff
    apk (aggressive) 585 kB 585 kB +7 B (+0.0%)
    apk (debug) 2.10 MB 2.10 MB +94 B (+0.0%)

Test Logs

@rlazo rlazo merged commit c0a592a into master Apr 28, 2020
@rlazo rlazo deleted the rl.missing_test branch May 13, 2020 14:59
@firebase firebase locked and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

@ashwinraghav ashwinraghav Awaiting requested review from ashwinraghav

@davidmotson davidmotson Awaiting requested review from davidmotson

Assignees
No one assigned
Labels
cla: yes Override cla size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rlazo @google-oss-bot @vkryachko @googlebot