Uncomment the Obsolete tags for deprecated FCM batch send APIs
#355
+14
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doris-Ge
force-pushed
the
fcm-batch-send
branch
2 times, most recently
from
a8575f7
to
47eb28c
Compare
lahirumaramba
requested changes
Jul 25, 2023
| @@ -124,78 +124,6 @@ public async Task SendEachForMulticast() | |||
| Assert.NotNull(response.Responses[1].Exception); | |||
| } | |||
|
|
|||
| [Fact] | |||
There was a problem hiding this comment.
Did you mean to remove this test?
There was a problem hiding this comment.
Yes. Because now SendAllAsync and SendMulticastAsync have been marked as obsolete, these two integration tests will fail: https://github.com/firebase/firebase-admin-dotnet/actions/runs/5661155177/job/15338452380 .
I also tried marking these two tests with "[Ignore]", but it could not build. Any suggestions?
There was a problem hiding this comment.
Thanks! Okay, let's remove them.
lahirumaramba
approved these changes
Jul 26, 2023
| @@ -124,78 +124,6 @@ public async Task SendEachForMulticast() | |||
| Assert.NotNull(response.Responses[1].Exception); | |||
| } | |||
|
|
|||
| [Fact] | |||
There was a problem hiding this comment.
Thanks! Okay, let's remove them.
|
Will you build a new package soon which has these obsolete tags? |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address the issue flagged in #349