Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subtitle in ApsAlert #219

Merged
merged 8 commits into from Nov 27, 2018
Merged

Add subtitle in ApsAlert #219

merged 8 commits into from Nov 27, 2018

Conversation

@chemidy
Copy link
Contributor

@chemidy chemidy commented Nov 23, 2018

Add subtitle field in ApsAlert payload + tests

Copy link
Member

@hiranya911 hiranya911 left a comment

Looks good. Just one additional test case required for completeness.

Loading

@hiranya911 hiranya911 self-assigned this Nov 26, 2018
Copy link
Member

@hiranya911 hiranya911 left a comment

LGTM

Loading

@hiranya911 hiranya911 merged commit 3bade2b into firebase:master Nov 27, 2018
2 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants