Apply suggestions from code review

Co-authored-by: pragatimodi <110490169+pragatimodi@users.noreply.github.com>
firebase · Apr 11, 2023 · 9986040 · 9986040
1 parent 8fb5f2a
commit 9986040
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 7 deletions.
diff --git a/src/auth/project-config.ts b/src/auth/project-config.ts
@@ -50,7 +50,6 @@ export interface UpdateProjectConfigRequest {
 
 /**
  * Response received when getting or updating the project config.
- * Currently only includes the reCAPTCHA and SMS Region config.
  */
 export interface ProjectConfigServerResponse {
   smsRegionConfig?: SmsRegionConfig;
@@ -60,7 +59,6 @@ export interface ProjectConfigServerResponse {
 
 /**
  * Request to update the project config.
- * Currently only includes the reCAPTCHA and SMS Region config.
  */
 export interface ProjectConfigClientRequest {
   smsRegionConfig?: SmsRegionConfig;
@@ -145,7 +143,7 @@ export class ProjectConfig {
    * Build the corresponding server request for a UpdateProjectConfigRequest object.
    * @param configOptions - The properties to convert to a server request.
    * @returns  The equivalent server request.
-   * 
+   *
    * @internal
    */
   public static buildServerRequest(configOptions: UpdateProjectConfigRequest): ProjectConfigClientRequest {

diff --git a/test/integration/auth.spec.ts b/test/integration/auth.spec.ts
@@ -1227,7 +1227,12 @@ describe('admin.auth', () => {
       multiFactorConfig: mfaConfig,
       recaptchaConfig: {
         emailPasswordEnforcementState:  'AUDIT',
-        managedRules: [{ endScore: 0.1, action: 'BLOCK' }],
+        managedRules: [
+          {
+            endScore: 0.1,
+            action: 'BLOCK',
+          },
+        ],
         useAccountDefender: true,
       },
     };
@@ -1263,7 +1268,12 @@ describe('admin.auth', () => {
       multiFactorConfig: mfaConfig,
       recaptchaConfig: {
         emailPasswordEnforcementState:  'AUDIT',
-        managedRules: [{ endScore: 0.1, action: 'BLOCK' }],
+        managedRules: [
+          {
+            endScore: 0.1,
+            action: 'BLOCK',
+          },
+        ],
         useAccountDefender: true,
       },
     };
@@ -1276,7 +1286,12 @@ describe('admin.auth', () => {
       multiFactorConfig: mfaConfig,
       recaptchaConfig: {
         emailPasswordEnforcementState:  'OFF',
-        managedRules: [{ endScore: 0.1, action: 'BLOCK' }],
+        managedRules: [
+          {
+            endScore: 0.1,
+            action: 'BLOCK',
+          },
+        ],
       },
     };
     const expectedProjectConfigSmsEnabledTotpDisabled: any = {
@@ -1293,7 +1308,12 @@ describe('admin.auth', () => {
       },
       recaptchaConfig: {
         emailPasswordEnforcementState:  'OFF',
-        managedRules: [{ endScore: 0.1, action: 'BLOCK' }],
+        managedRules: [
+          {
+            endScore: 0.1,
+            action: 'BLOCK',
+          },
+        ],
       },
     };