Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define SSRC API #2456

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Define SSRC API #2456

merged 2 commits into from
Feb 14, 2024

Conversation

erikeldridge
Copy link
Contributor

This is an incremental change to define the API.

Discussion

Working with @lahirumaramba.

Testing

Ran npm test and all tests pass.

lahirumaramba
lahirumaramba approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@erikeldridge erikeldridge mentioned this pull request Feb 13, 2024
Merged
@erikeldridge erikeldridge merged commit bd9d4d8 into ssrc Feb 14, 2024
5 checks passed
@erikeldridge erikeldridge deleted the ssrc-api branch February 14, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Assignees

@erikeldridge erikeldridge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erikeldridge @lahirumaramba @trekforever