Update SSRC API client #2457
Update SSRC API client #2457
Conversation
|
|
||
| // Remote Config backend constants | ||
| const FIREBASE_REMOTE_CONFIG_V1_API = 'https://firebaseremoteconfig.googleapis.com/v1'; | ||
| // Honors env param to enable URL override independent of binary change. | ||
| const FIREBASE_REMOTE_CONFIG_URL_BASE = process.env.FIREBASE_REMOTE_CONFIG_URL_BASE || 'https://firebaseremoteconfig.googleapis.com'; |
There was a problem hiding this comment.
@lahirumaramba I've found it helpful here and in the Web SDK to be able to point the SDK at a local server for testing while in development, and issue reproduction after release. I don't see other references to process.env in this SDK, though. Do you have a preferred way to reference an env var?
There was a problem hiding this comment.
Thanks! This makes sense to me. We use process.env to handle other env variables
Let's make a note to document this new env var in our public docs
There was a problem hiding this comment.
Added a row to our burndown to document this env var.
|
|
||
| // Remote Config backend constants | ||
| const FIREBASE_REMOTE_CONFIG_V1_API = 'https://firebaseremoteconfig.googleapis.com/v1'; | ||
| // Honors env param to enable URL override independent of binary change. | ||
| const FIREBASE_REMOTE_CONFIG_URL_BASE = process.env.FIREBASE_REMOTE_CONFIG_URL_BASE || 'https://firebaseremoteconfig.googleapis.com'; |
There was a problem hiding this comment.
Thanks! This makes sense to me. We use process.env to handle other env variables
Let's make a note to document this new env var in our public docs
| * Interface representing a Remote Config condition in the data-plane. | ||
| * A condition targets a specific group of users. A list of these conditions make up | ||
| * part of a Remote Config template. | ||
| */ |
There was a problem hiding this comment.
Let's get TW reviews on these. Thanks!
There was a problem hiding this comment.
Ah. Good point. I was focused on this being an internal client and overlooked that it updated the API. I've added @jenh as a reviewer.
Co-authored-by: jen_h <harveyjen@google.com>
|
Thank you for reviewing, @lahirumaramba, @jenh! @jenh, I've updated the PR with your suggested changes and re-requested review from you. |
Internal client updates.
This is based on PR #2456, which defined the API.
Discussion
Working with @lahirumaramba and @trekforever.
Testing
Ran npm test and all tests pass.