Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public SSRC methods #2458

Merged
merged 14 commits into from
Mar 5, 2024
Merged

Add public SSRC methods #2458

merged 14 commits into from
Mar 5, 2024

Conversation

erikeldridge
Copy link
Contributor

Internal client updates.

This is based on PR #2457, which updated the API client.

Discussion

Working with @lahirumaramba and @trekforever.

Testing

Ran npm test and all tests pass.

@erikeldridge erikeldridge self-assigned this Feb 14, 2024
src/remote-config/remote-config-api.ts Outdated Show resolved Hide resolved
src/remote-config/remote-config.ts Outdated Show resolved Hide resolved
src/remote-config/remote-config.ts Outdated Show resolved Hide resolved
src/remote-config/remote-config.ts Outdated Show resolved Hide resolved
src/remote-config/remote-config.ts Outdated Show resolved Hide resolved
src/remote-config/remote-config.ts Outdated Show resolved Hide resolved
test/integration/remote-config.spec.ts Outdated Show resolved Hide resolved
test/integration/remote-config.spec.ts Outdated Show resolved Hide resolved
Base automatically changed from ssrc-client-internals to ssrc February 20, 2024 16:51
@erikeldridge
Copy link
Contributor Author

Thank you for reviewing, @jenh. I've updated this PR with your suggested changes.

test/unit/remote-config/remote-config.spec.ts Outdated Show resolved Hide resolved
test/unit/remote-config/remote-config.spec.ts Outdated Show resolved Hide resolved
Co-authored-by: jen_h <harveyjen@google.com>
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed the logging offline. LGTM!

src/remote-config/remote-config-api.ts Show resolved Hide resolved
src/remote-config/remote-config.ts Outdated Show resolved Hide resolved
src/remote-config/remote-config.ts Outdated Show resolved Hide resolved
@erikeldridge erikeldridge merged commit 5c9b649 into ssrc Mar 5, 2024
5 checks passed
@erikeldridge erikeldridge deleted the ssrc-rc branch March 5, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants