Remote Config Add list versions operation #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahirumaramba
commented
May 20, 2020
| @@ -361,7 +480,7 @@ describe('RemoteConfigApiClient', () => { | |||
| }); | |||
| } | |||
|
|
|||
| function runErrorResponseTests(rcOperation: () => Promise<RemoteConfigTemplate>): void { | |||
| function runEtagHeaderTests(rcOperation: () => Promise<RemoteConfigTemplate>): void { | |||
There was a problem hiding this comment.
Added this function to extract etag header validation tests from runErrorResponseTests function. That way I could re-use runErrorResponseTests for list versions operation. :)
hiranya911
suggested changes
May 20, 2020
lahirumaramba
force-pushed
the
lm-rc-listversions
branch
from
c8603e9
to
c6392fe
Compare
hiranya911
suggested changes
Jun 8, 2020
lahirumaramba
commented
Jun 9, 2020
hiranya911
reviewed
Jun 9, 2020
hiranya911
suggested changes
Jun 9, 2020
lahirumaramba
added a commit
that referenced
this pull request
Jun 25, 2020
* Get remote config template by version number (#874) * Get remote config template by version number * Refactor unit tests for Remote Config (#884) * Refactor unit tests * Add Remote Config Rollback operation (#885) * Add Remote Config Rollback operation * Update docs and move etag validation to a helper function * Update docs * Introduce a util to create a template from API response * PR fixes * Remote Config Add list versions operation (#896) * Remote Config: Add list versions operation * Add version Impl and other PR fixes * PR fixes * Imrpoved unit tests and some code clean up * Fix code formatting * Add a separate function to get a Template with version (#902) * Add version meta data to RC templates (#906) * Add version meta data to RC templates * PR fixes * Use assertion to unwrap template.version * Update Remote Config Docstrings in index.d.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Integration tests for all the new operations will be added in a separate PR.