Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a separate function for getting a Template with version number #902

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

lahirumaramba
Copy link
Member

  • Add getTemplateAtVersion() for getting a RC template with a version number
  • Revert getTemplate() to only access the active RC template of a project
  • Add unit tests for getTemplateAtVersion

Note: All integration tests for go/admin-sdk-remote-config-change-history will be added in a separate PR

Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lahirumaramba lahirumaramba merged commit 16b20f1 into remote-config-vc Jun 12, 2020
@lahirumaramba lahirumaramba deleted the lm-rc-get-version branch June 12, 2020 19:48
lahirumaramba added a commit that referenced this pull request Jun 25, 2020
* Get remote config template by version number (#874)

* Get remote config template by version number

* Refactor unit tests for Remote Config (#884)

* Refactor unit tests

* Add Remote Config Rollback operation (#885)

* Add Remote Config Rollback operation

* Update docs and move etag validation to a helper function

* Update docs

* Introduce a util to create a template from API response

* PR fixes

* Remote Config Add list versions operation (#896)

* Remote Config: Add list versions operation

* Add version Impl and other PR fixes

* PR fixes

* Imrpoved unit tests and some code clean up

* Fix code formatting

* Add a separate function to get a Template with version (#902)

* Add version meta data to RC templates (#906)

* Add version meta data to RC templates

* PR fixes

* Use assertion to unwrap template.version

* Update Remote Config Docstrings in index.d.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants