Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: Support arbitrary key-value pairs in messaging.ApsAlert #245

Closed
hiranya911 opened this issue Jan 11, 2019 · 1 comment · Fixed by #322
Closed

FR: Support arbitrary key-value pairs in messaging.ApsAlert #245

hiranya911 opened this issue Jan 11, 2019 · 1 comment · Fixed by #322
Labels
api: messaging help wanted

Comments

@hiranya911
Copy link
Contributor

hiranya911 commented Jan 11, 2019 •
edited
Loading

ApsAlert type should support specifying custom key-value pairs, as the APNS spec regularly adds new parameters into this struct (e.g. summary-arg, summary-arg-count etc).
@google-oss-bot
Copy link

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

@hiranya911 hiranya911 changed the title Support arbitrary key-value pairs in messaging.ApsAlert FR: Support arbitrary key-value pairs in messaging.ApsAlert Jan 11, 2019
@viktorasl viktorasl mentioned this issue Aug 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: messaging help wanted
Projects
None yet
Milestone
No milestone
2 participants
@hiranya911 @google-oss-bot