Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fcm): Added support for arbitrary key-value pairs in `messaging.ApsAlert` #322

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@viktorasl
Copy link
Contributor

commented Aug 14, 2019

NB: If arbitrary key-value dictionary contains key matching already supported key, it overrides the value. The motivation behind this is that if Apple will start accepting other value type than API provides API consumer will still be able to specify that (case covered w/ unit test)

It does affect the public API, but in a backwards compatible way, so I believe it's good to go?
Closes #245

@viktorasl viktorasl force-pushed the viktorasl:apsalert-custom-key-values branch from 69faac3 to be556d2 Aug 14, 2019

@hiranya911
Copy link
Member

left a comment

LGTM. Thanks 👍

@hiranya911 hiranya911 changed the title Add support for arbitrary key-value pairs in messaging.ApsAlert feat(fcm): Added support for arbitrary key-value pairs in `messaging.ApsAlert` Aug 14, 2019

@hiranya911 hiranya911 self-assigned this Aug 14, 2019

@hiranya911 hiranya911 merged commit 5408fbc into firebase:master Aug 14, 2019

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.