Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup to #400 to ensure all new types are exported #461

Merged
merged 5 commits into from
May 13, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions firebase_admin/_auth_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ def get_users(self, identifiers):

Returns:
GetUsersResult: A ``GetUsersResult`` instance corresponding to the
specified identifiers.
specified identifiers.

Raises:
ValueError: If any of the identifiers are invalid or if more than 100
Expand Down Expand Up @@ -374,8 +374,8 @@ def delete_users(self, uids):

Returns:
DeleteUsersResult: The total number of successful/failed deletions, as
well as the array of errors that correspond to the failed
deletions.
well as the array of errors that correspond to the failed
deletions.

Raises:
ValueError: If any of the identifiers are invalid or if more than 1000
Expand Down
2 changes: 1 addition & 1 deletion firebase_admin/_auth_providers.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def get_next_page(self):

Returns:
ListProviderConfigsPage: Next page of provider configs, or None if this is the last
page.
page.
"""
if self.has_next_page:
return self.__class__(self._download, self.next_page_token, self._max_results)
Expand Down
6 changes: 3 additions & 3 deletions firebase_admin/_user_mgt.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def last_refresh_timestamp(self):

Returns:
integer: Milliseconds since epoch timestamp, or `None` if the user was
never active.
never active.
"""
return self._last_refresh_timestamp

Expand Down Expand Up @@ -215,7 +215,7 @@ def tokens_valid_after_timestamp(self):

Returns:
int: Timestamp in milliseconds since the epoch, truncated to the second.
All tokens issued before that time are considered revoked.
All tokens issued before that time are considered revoked.
"""
valid_since = self._data.get('validSince')
if valid_since is not None:
Expand Down Expand Up @@ -752,7 +752,7 @@ def delete_users(self, uids, force_delete=False):

Returns:
BatchDeleteAccountsResponse: Server's proto response, wrapped in a
python object.
python object.

Raises:
ValueError: If any of the identifiers are invalid or if more than 1000
Expand Down
13 changes: 7 additions & 6 deletions firebase_admin/auth.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@
'ExpiredIdTokenError',
'ExpiredSessionCookieError',
'ExportedUserRecord',
'DeleteUsersResult',
'GetUsersResult',
'ImportUserRecord',
'InsufficientPermissionError',
'InvalidDynamicLinkDomainError',
Expand Down Expand Up @@ -356,14 +358,14 @@ def get_users(identifiers, app=None):
identifiers are supplied, this method raises a `ValueError`.

Args:
identifiers (list[Identifier]): A list of ``Identifier`` instances used
to indicate which user records should be returned. Must have <= 100
entries.
identifiers (list[UserIdentifier]): A list of ``UserIdentifier``
instances used to indicate which user records should be returned.
Must have <= 100 entries.
app: An App instance (optional).

Returns:
GetUsersResult: A ``GetUsersResult`` instance corresponding to the
specified identifiers.
specified identifiers.
hiranya911 marked this conversation as resolved.
Show resolved Hide resolved

Raises:
ValueError: If any of the identifiers are invalid or if more than 100
Expand Down Expand Up @@ -522,8 +524,7 @@ def delete_users(uids, app=None):

Returns:
DeleteUsersResult: The total number of successful/failed deletions, as
well as the array of errors that correspond to the failed
deletions.
well as the array of errors that correspond to the failed deletions.

Raises:
ValueError: If any of the identifiers are invalid or if more than 1000
Expand Down