Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followup to #400 to ensure all new types are exported #461

Merged
merged 5 commits into from May 13, 2020
Merged

Followup to #400 to ensure all new types are exported #461

merged 5 commits into from May 13, 2020

Conversation

rsgowman
Copy link
Member

No description provided.

@rsgowman rsgowman requested a review from hiranya911 May 12, 2020 22:06
hiranya911
hiranya911 suggested changes May 12, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Spotted one typo.

firebase_admin/auth.py Show resolved Hide resolved
@hiranya911 hiranya911 assigned rsgowman and unassigned hiranya911 May 12, 2020
@rsgowman rsgowman assigned hiranya911 and unassigned rsgowman May 12, 2020
hiranya911
hiranya911 approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

@hiranya911 hiranya911 assigned rsgowman and unassigned hiranya911 May 12, 2020
@rsgowman rsgowman merged commit f8b1fff into master May 13, 2020
@rsgowman rsgowman deleted the rsgowman/newtypes_bulkgetdelete branch May 13, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiranya911 hiranya911 hiranya911 approved these changes

Assignees

@rsgowman rsgowman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rsgowman @hiranya911