Documentation or nullability annotation of FirebaseDynamicLinks.getDynamicLink() intent parameter wrong

[ubuntudroid]

The documentation of

firebase-android-sdk/firebase-dynamic-links/src/main/java/com/google/firebase/dynamiclinks/FirebaseDynamicLinks.java

Line 102 in 6ccc9de

public abstract Task<PendingDynamicLinkData> getDynamicLink(@NonNull Intent intent);

states, that the intent parameter

can be null if the intent does not include the dynamic link. A non-null intent is necessary only when the app is launched directly using the dynamic link, such as when using App Links.

However the parameter is annotated with @NonNull. So either the documentation or the annotation is wrong and needs adaptation.

[google-oss-bot]

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

[rlazo]

Hi @ubuntudroid, thanks for your report! The documentation is wrong, since the method implementing that interface does in fact expect the value to be non-null

firebase-android-sdk/firebase-dynamic-links/src/main/java/com/google/firebase/dynamiclinks/internal/FirebaseDynamicLinksImpl.java

Line 95 in 6ccc9de

public Task<PendingDynamicLinkData> getDynamicLink(@NonNull final Intent intent) {

I'll follow up here when we have a fix ready.

[rohandandavati]

b/178000308

[davidmigloz]

What is the expected usage when you only care about the captured dynamic link after install? (e.g. because you have your own deep linking mechanism to handle app links that doesn't rely on Firebase Dynamic Links)

It'd good to have a getDynamicLink() without any parameters for that case (or allow to pass null as the documentation was suggesting before).

[eldhosembabu]

Added a fix here: #2629

[mikehardy]

This just bit us on react-native-firebase. We were coded up to wrap the API per docs, but a user took a null pointer exception because the implementation expects non-null

invertase/react-native-firebase#5662

[eldhosembabu]

#2629 is merged. Expect the fix to be rolled out in upcoming releases. So closing this issue now.